Hpack optimizations
#7086
Merged
Hpack optimizations
#7086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: "Diego E. Alonso" <diesalbla@gmail.com>
armanbilge
commented
Apr 23, 2023
| val decoded = buffer.toList | ||
| NonEmptyList.fromList(decoded).toRight(new NoSuchElementException("Header List Was Empty")) | ||
| }.rethrow | ||
| val decoded = buffer.result() | ||
| NonEmptyList.fromListUnsafe(decoded) | ||
| } |
There was a problem hiding this comment.
Oh, forgot to mention: we can use fromListUnsafe because we are in a delay(...) block anyway, and skip the .rethrow.
danicheg
approved these changes
Apr 26, 2023
ChristopherDavenport
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ByteVector#toInputStreamandByteVectorOuputStreamfor copy-free conversionsList.newBuilderinstead ofListBuffer(not sure if this makes a difference, but intent is clearer)Mutexinstead ofSempahore(1)(performance is optimized and communicates intent)