Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more examples to the doc ( shortcut to create Responses) #7120

Merged
merged 3 commits into from
May 21, 2023

Conversation

walesho
Copy link
Contributor

@walesho walesho commented May 18, 2023

No description provided.

@mergify mergify bot added series/0.23 PRs targeting 0.23.x docs Relates to our website or tutorials labels May 18, 2023
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

docs/docs/dsl.md Outdated
Comment on lines 134 to 136
HttpRoutes.of[IO]{
case _ => Conflict()
}.orNotFound.run(getRoot).unsafeRunSync()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just a nit. Can you format these like the ones above?

Suggested change
HttpRoutes.of[IO]{
case _ => Conflict()
}.orNotFound.run(getRoot).unsafeRunSync()
HttpRoutes.of[IO] {
case _ => Conflict()
}.orNotFound.run(getRoot).unsafeRunSync()

docs/docs/dsl.md Outdated Show resolved Hide resolved
docs/docs/dsl.md Outdated Show resolved Hide resolved
docs/docs/dsl.md Outdated Show resolved Hide resolved
@armanbilge armanbilge merged commit e7f8fae into http4s:series/0.23 May 21, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Relates to our website or tutorials series/0.23 PRs targeting 0.23.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants