Add missing constructors to ContextRoutes #7123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some useful constructors to ContextRoutes that existed on HttpRoutes.
hamnis
force-pushed
the
contextroutes-constructors
branch
2 times, most recently
from
63fca36
to
1092c52
Compare
* fixup some docs
hamnis
force-pushed
the
contextroutes-constructors
branch
from
1092c52
to
21d7a6a
Compare
danicheg
reviewed
May 24, 2023
hamnis
force-pushed
the
contextroutes-constructors
branch
from
a759e95
to
4459251
Compare
danicheg
approved these changes
May 24, 2023
| */ | ||
| def local[T, F[_]: Monad](f: ContextRequest[F, T] => ContextRequest[F, T])( | ||
| fa: ContextRoutes[T, F] | ||
| ): ContextRoutes[T, F] = Kleisli(req => Monad[OptionT[F, *]].unit >> fa.run(f(req))) |
There was a problem hiding this comment.
Perhaps I'm missing something, but do we need here flatmapping over F[Unit]?
There was a problem hiding this comment.
I guess it is similar to Http.local – i.e. deferring without the Defer constraint per se.
There was a problem hiding this comment.
Yeah, thank you. I rather meant, is this a thing actually (in this particular use-case)?
There was a problem hiding this comment.
We don't know if the effect within the Kleisli fa is deferred, so this is just to make sure it is.
There was a problem hiding this comment.
Is it all about awareness of whether the F has eager semantics of computation?
hamnis
force-pushed
the
contextroutes-constructors
branch
from
4459251
to
4f3e4e8
Compare
Co-authored-by: Daniel Esik <e.danicheg@yandex.ru>
hamnis
force-pushed
the
contextroutes-constructors
branch
from
4f3e4e8
to
0a66f72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some useful constructors to ContextRoutes that existed on HttpRoutes.