Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QueryOps#setQueryParams scaladoc #7126

Merged
merged 1 commit into from Jun 23, 2023
Merged

Fix QueryOps#setQueryParams scaladoc #7126

merged 1 commit into from Jun 23, 2023

Conversation

danicheg
Copy link
Member

This is a follow-up to #7106. Whatever we decide about changing the Queries API, this scaladoc is misleading, and we can fix it sooner.

@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:core labels May 27, 2023
@armanbilge
Copy link
Member

thanks daniel :)

@armanbilge armanbilge merged commit 5e95b3c into http4s:series/0.23 Jun 23, 2023
16 checks passed
@danicheg danicheg deleted the uri-set-query-params branch June 23, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
module:core series/0.23 PRs targeting 0.23.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danicheg @armanbilge