Use ClockOps in ResponseTiming Middleware
#7163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
reviewed
Jun 15, 2023
| @@ -43,12 +44,9 @@ object ResponseTiming { | |||
| headerName: CIString = ci"X-Response-Time", | |||
| )(implicit F: Sync[F], clock: Clock[F]): HttpApp[F] = | |||
There was a problem hiding this comment.
Sync extends Clock, so including both is ambiguous.
There was a problem hiding this comment.
I can do this refactoring too 👍🏻
There was a problem hiding this comment.
But wait. What's about MiMa?
There was a problem hiding this comment.
Come on, you know the drill 😛
@deprecated
def apply[F[_]](
http: HttpApp[F],
timeUnit: TimeUnit,
headerName: CIString,
F: Sync[F],
clock: Clock[F]
) = ???There was a problem hiding this comment.
Actually, why do we even need Sync here?
There was a problem hiding this comment.
Functor + Clock should work well if you wanna get purity at max 😄
There was a problem hiding this comment.
Have we beaten all the dragons?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.