Immediately release invalid connections in getValidManaged
#7218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
series/0.23
armanbilge
changed the title
getValidManagedgetValidManaged
ChristopherDavenport
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7216.
Previously, if an invalid connection was obtained from the pool, instead of returning it back to the pool so that it could dispose/recycle it, we would continue
flatMapping resources until we could obtain a valid connection. Thus we'd retain leases to the invalid connections much longer than necessary, which is problematic when the pool itself has a limited number of slots.By using a
Hotswapwe can release the invalid connection immediately before attempting to obtain a new one.