Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Jsonp Middleware #7285

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Deprecate Jsonp Middleware #7285

merged 3 commits into from
Sep 21, 2023

Conversation

froth
Copy link
Member

@froth froth commented Sep 20, 2023

fixes #6959

@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:server docs Relates to our website or tutorials labels Sep 20, 2023
@froth froth force-pushed the deprecate-jsonp-middleware-0.23 branch from c944f91 to ceb2b0e Compare September 20, 2023 13:28
armanbilge
armanbilge reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for chasing up on this! Looks great, let's point out that we are completely removing it.

server/shared/src/main/scala/org/http4s/server/middleware/Jsonp.scala Outdated Show resolved Hide resolved
@froth
Copy link
Member Author

froth commented Sep 20, 2023

Thanks for chasing up on this! Looks great, let's point out that we are completely removing it.

Good point. I have accepted your change.

@froth
Copy link
Member Author

froth commented Sep 20, 2023

OK. I will run scalafmt tomorrow ;)

@froth @armanbilge
Make clear Jsonp middleware is removed in 1.0
ea83a92 
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
@froth froth force-pushed the deprecate-jsonp-middleware-0.23 branch from 1f6d95d to ea83a92 Compare September 21, 2023 05:47
@froth
Copy link
Member Author

froth commented Sep 21, 2023

Pipelines are appeased

danicheg
danicheg approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@armanbilge armanbilge merged commit e841a40 into http4s:series/0.23 Sep 21, 2023
16 checks passed
@froth froth deleted the deprecate-jsonp-middleware-0.23 branch September 21, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge left review comments

@danicheg danicheg danicheg approved these changes

Assignees
No one assigned
Labels
docs Relates to our website or tutorials module:server series/0.23 PRs targeting 0.23.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate Jsonp middleware?
3 participants
@froth @armanbilge @danicheg