Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cats-parse to 1.0.0 in series/0.23 #7313

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

http4s-steward[bot]
Copy link
Contributor

@http4s-steward http4s-steward bot commented Nov 7, 2023

About this PR

πŸ“¦ Updates org.typelevel:cats-parse from 0.3.10 to 1.0.0 ⚠

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

πŸ” Files still referring to the old version number

The following files still refer to the old version number (0.3.10).
You might want to review and update them manually.

docs/changelog.md
βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.typelevel", artifactId = "cats-parse" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.typelevel", artifactId = "cats-parse" }
}]
labels: library-update, early-semver-major, semver-spec-major, version-scheme:early-semver, old-version-remains, commit-count:1

@mergify mergify bot added series/0.23 PRs targeting 0.23.x dependencies Dependency updates labels Nov 7, 2023
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so we need to decide what to do here ...

cats-parse has released 1.0.0 which is 100% binary-compatible with the 0.3.x series. So there is no real harm to do this upgrade.

The only annoying thing is that sbt will give eviction errors because it does not know that cats-parse 1.x is compatible with 0.3.x. This can be annoying whether we stay on 0.3.x or go to 1.x, depending on what other libraries a user has and which version they depend on.

So I think the best path is to move forward and ideally all libraries depending on cats-parse will be able to release new versions against 1.x as well, and make the eviction errors go away.

The other option is we stay conservative in this 0.23.x series, but that means no more cats-parse updates.

Thoughts?

@armanbilge
Copy link
Member

Besides http4s and Grackle, are there any other Typelevel ecosystem libraries that depend on cats-parse? At the very least we can coordinate with them. (Grackle is going to v1.0.0).

@rossabaker
Copy link
Member

rossabaker commented Nov 9, 2023

It's going to be painful either way until everything resynchronizes, so it might as well be painful on the side of the maintained series. Go 1.0.

@armanbilge armanbilge merged commit f2b8f41 into series/0.23 Nov 9, 2023
18 checks passed
@armanbilge armanbilge deleted the update/series/0.23/cats-parse-1.0.0 branch November 9, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency updates series/0.23 PRs targeting 0.23.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants