Align the server and client idle timeouts in Ember #7329
Conversation
mergify
bot
added
series/0.23
| val idleConnectionTime: FiniteDuration = org.http4s.client.defaults.RequestTimeout | ||
| val timeout: Duration = org.http4s.client.defaults.RequestTimeout | ||
| val idleConnectionTime: FiniteDuration = org.http4s.ember.core.Defaults.idleTimeout | ||
| val timeout: Duration = org.http4s.ember.core.Defaults.idleTimeout |
There was a problem hiding this comment.
Hmm, maybe changing the default timeout is not desired. I was thinking that 45s is quite a lot but 60s 🤯
There was a problem hiding this comment.
My bad 😬 . I reverted the timeout from previous value.
| import scala.concurrent.duration.FiniteDuration | ||
|
|
||
| private[ember] object Defaults { | ||
| val idleTimeout: FiniteDuration = 60.seconds |
There was a problem hiding this comment.
We have different notations for such vals over the codebase, but maybe PascalCase better fits. wdyt?
There was a problem hiding this comment.
That's interesting. I saw camelCase and PascalCase vals in this project but how do you choose between eatch other ?
|
I agree with having a single source of truth for general client/server defaults. I doubt a little about putting it into |
There was a problem hiding this comment.
Thanks @rlavolee for your efforts here.
The technical approach seems fine.
Because this is a change of behaviour, we need to remember to call it our clearly in our next release notes.
(edit: just wanted to link the brief discussion about whether this change can go in a patch release: #7327 (comment))
|
Thanks again @rlavolee! |
Fixes: #7327