Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the outdated code snippet in the client dsl scaladoc #7381

Merged
merged 1 commit into from Mar 4, 2024
Merged

Fix the outdated code snippet in the client dsl scaladoc #7381

merged 1 commit into from Mar 4, 2024

Conversation

danicheg
Copy link
Member

It appears that this scaladoc is completely outdated. But it's intended to be frequently peeked at, so let's at least refresh it.

@danicheg danicheg added the docs Relates to our website or tutorials label Feb 16, 2024
@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:client labels Feb 16, 2024
@danicheg
Copy link
Member Author

@http4s/core hey folks, your review of this small PR would be highly appreciated 🙇🏻‍♂️

hamnis
hamnis approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@hamnis hamnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the entire client dsl should be removed for 1.0.

But in 0.23 this is good, thanks for looking into this. Sorry for the lateness of response.

@rossabaker rossabaker merged commit 5d04fd8 into http4s:series/0.23 Mar 4, 2024
17 checks passed
@danicheg danicheg deleted the fix-client-dsl-scaladoc branch March 4, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamnis hamnis hamnis approved these changes

@rossabaker rossabaker rossabaker approved these changes

Assignees
No one assigned
Labels
docs Relates to our website or tutorials module:client series/0.23 PRs targeting 0.23.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danicheg @hamnis @rossabaker