Merge 0.23 -> main #7387
Merged
Merge 0.23 -> main #7387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
Next FS2 upgrade will include the changes in typelevel/fs2#3264 This could have an impact on the performance of this loop.
…-log-request-body Add asCurlWithBody
….1.38 Update scodec-bits to 1.1.38 in series/0.23
Update sbt to 1.9.7 in series/0.23
…-3.7.15 Update scalafmt-core to 3.7.15 in series/0.23
Flake lock file updates:
• Updated input 'typelevel-nix':
'github:typelevel/typelevel-nix/6d5aa0fe626b2b8f899660caeb1a288fe4112213' (2023-10-09)
→ 'github:typelevel/typelevel-nix/5c281f550dcb73eafe7341767d384bcdc3ec14fd' (2023-10-30)
• Updated input 'typelevel-nix/devshell':
'github:numtide/devshell/cd4e2fda3150dd2f689caeac07b7f47df5197c31' (2023-09-29)
→ 'github:numtide/devshell/1aed986e3c81a4f6698e85a7452cbfcc4b31a36e' (2023-10-27)
• Updated input 'typelevel-nix/nixpkgs':
'github:nixos/nixpkgs/5aabb5780a11c500981993d49ee93cfa6df9307b' (2023-10-08)
→ 'github:nixos/nixpkgs/90e85bc7c1a6fc0760a94ace129d3a1c61c3d035' (2023-10-29)
flake.lock: Update
…-2.0.11 Update sbt-scoverage to 2.0.11 in series/0.23
mergify
bot
added
module:core
module:ember-core
module:ember-server
module:ember-client
module:client-testkit
docs
danicheg
reviewed
Feb 26, 2024
This reverts commit e88bef4.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #7387 +/- ##
==========================================
+ Coverage 77.46% 77.56% +0.10%
==========================================
Files 333 335 +2
Lines 10228 10266 +38
Branches 1109 1134 +25
==========================================
+ Hits 7923 7963 +40
+ Misses 2305 2303 -2 ☔ View full report in Codecov by Sentry. |
Flake lock file updates:
• Updated input 'typelevel-nix':
'github:typelevel/typelevel-nix/85318b2ace46ee59560d5a5ce1a56ee08b46b15e' (2024-02-12)
→ 'github:typelevel/typelevel-nix/035bec68f65a213bf6080c7aeb18ba88b9fe9b5f' (2024-02-26)
• Updated input 'typelevel-nix/nixpkgs':
'github:nixos/nixpkgs/f3a93440fbfff8a74350f4791332a19282cc6dc8' (2024-02-11)
→ 'github:nixos/nixpkgs/2a34566b67bef34c551f204063faeecc444ae9da' (2024-02-25)
flake.lock: Update
…g-0.16.3 Update sbt-http4s-org to 0.16.3 in series/0.23
danicheg
reviewed
Mar 4, 2024
|
Hey folks @http4s/core would you mind giving this a quick review so we can finally call it a day? |
…y-3.3.3 Update scala3-library, ... to 3.3.3 in series/0.23
valencik
approved these changes
Mar 4, 2024
| * this may cause, which may consume large amounts of memory to cache a request that streams a | ||
| * large amount of data. | ||
| */ | ||
| def asCurlWithBody(redactHeadersWhen: CIString => Boolean = Headers.SensitiveHeaders.contains)( |
There was a problem hiding this comment.
Just to confirm I understand, this is the same as what was added to 0.23 in 62a19ca
but is wrapped in an implicit class to help handle that Concurrent is invariant, but Request is now covariant?
There was a problem hiding this comment.
Ross better knows, but as far as I understand, yeah it's because Request is covariant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while. It wasn't too bad.
RequestOpswas necessary due to the variance change onRequestand the implicit evidence parameter on a new operation.Resets things as #7386 gets pondered.