Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember: return HTTP 431 when maxHeaderSize is exceeded #7399

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

rossabaker
Copy link
Member

  • Adds a maxHeaderSizeErrorHandler property to EmberServerBuilder
  • The default returns an empty 431 response when the default message length is exceeded. Currently, we return a 500.

I don't love the proliferation of options, but I think this is in the original spirit of the errorHandler. This needs a rethink in 1.0.

Fixes #7395.

@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:ember-server labels Mar 4, 2024
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyV1
... Anyway, in the current design, this is perhaps the only way to embed error handling properly.

@rossabaker
Copy link
Member Author

The simpler way is just to add a case to the default errorHandler, but even the example apps obliterate the default instead of composing it. 🤷

@rossabaker rossabaker merged commit 84cbf17 into series/0.23 Mar 4, 2024
34 checks passed
@rossabaker rossabaker deleted the issue-7395 branch March 5, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ember server returns 500 on too many headers, doesn't say why
3 participants