New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution for issue 1098 - prompted passwords are not properly persisted into sessions #1239
Solution for issue 1098 - prompted passwords are not properly persisted into sessions #1239
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1239 +/- ##
==========================================
- Coverage 97.28% 96.56% -0.73%
==========================================
Files 67 85 +18
Lines 4235 5729 +1494
==========================================
+ Hits 4120 5532 +1412
- Misses 115 197 +82
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The solution seems a bit localized, see my comments. Other than that; I am not really a big fan of storing raw passwords locally, so I would personally go with re-asking it rather than storing it as plain text. CC: @jakubroztocil on the product decision
…ock.patch while prompting for password
d7c3185
to
40c3ef6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR @sebastianczech. I've noticed that the change you have made on the has_password
broke the use case of empty passwords, so I manually fixed it and pushed it. The rest LGTM. Amazing first contribution 🎉
Thank you @isidentical for review, fixing |
Pull request is proposition of solution for the issue #1098 , where prompted passwords are not properly persisted into sessions. Below is an example how it works after applying solution:
This is my first contribution into open source, so all feedback is more than welcome ;)