Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip out extra variables from the actual mime type #1244

Merged
merged 3 commits into from Dec 16, 2021

Conversation

isidentical
Copy link
Contributor

Resolves #1242. We used to pass the whole Content-Type header as the mime (including the stuff like ;charset=utf-8 and other variables), with this patch we now only pass the actual mime type.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2021

Codecov Report

Merging #1244 (c8d8bcf) into master (4d7d6b6) will decrease coverage by 0.53%.
The diff coverage is 95.09%.

❗ Current head c8d8bcf differs from pull request most recent head 39c0e46. Consider uploading reports for the commit 39c0e46 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1244      +/-   ##
==========================================
- Coverage   97.28%   96.75%   -0.54%     
==========================================
  Files          67       81      +14     
  Lines        4235     5447    +1212     
==========================================
+ Hits         4120     5270    +1150     
- Misses        115      177      +62     
Impacted Files Coverage Δ
tests/test_binary.py 100.00% <ø> (ø)
httpie/compat.py 31.11% <27.90%> (-68.89%) ⬇️
tests/conftest.py 77.14% <58.33%> (-9.82%) ⬇️
tests/test_ssl.py 91.01% <66.66%> (-3.93%) ⬇️
httpie/manager/__main__.py 82.35% <82.35%> (ø)
httpie/models.py 94.73% <83.33%> (-2.64%) ⬇️
httpie/output/formatters/colors.py 92.66% <88.88%> (-0.92%) ⬇️
httpie/manager/core.py 92.85% <92.85%> (ø)
httpie/manager/plugins.py 93.39% <93.39%> (ø)
httpie/cli/json_form.py 93.87% <93.87%> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db1cdb...39c0e46. Read the comment docs.

tests/utils/http_server.py Outdated Show resolved Hide resolved
tests/test_output.py Outdated Show resolved Hide resolved
Copy link
Member

@jkbrzt jkbrzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also want to mention this in the changelog I believe

CHANGELOG.md Outdated Show resolved Hide resolved
@jkbrzt jkbrzt merged commit 2b78d04 into httpie:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No syntax highlighting possibly for content-types with charset
3 participants