Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --raw with --chunked #1254

Merged
merged 3 commits into from Dec 29, 2021
Merged

Fix --raw with --chunked #1254

merged 3 commits into from Dec 29, 2021

Conversation

isidentical
Copy link
Contributor

Resolves #1253. This is also a rewrite of the core uploading logic.

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2021

Codecov Report

Merging #1254 (b2032dd) into master (4d7d6b6) will decrease coverage by 0.76%.
The diff coverage is 94.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
- Coverage   97.28%   96.52%   -0.77%     
==========================================
  Files          67       85      +18     
  Lines        4235     5754    +1519     
==========================================
+ Hits         4120     5554    +1434     
- Misses        115      200      +85     
Impacted Files Coverage Δ
tests/test_binary.py 100.00% <ø> (ø)
httpie/compat.py 31.11% <27.90%> (-68.89%) ⬇️
tests/conftest.py 77.14% <58.33%> (-9.82%) ⬇️
httpie/output/lexers/http.py 59.09% <59.09%> (ø)
tests/test_ssl.py 91.01% <66.66%> (-3.93%) ⬇️
httpie/output/lexers/common.py 75.00% <75.00%> (ø)
httpie/output/lexers/metadata.py 81.25% <81.25%> (ø)
httpie/manager/__main__.py 82.35% <82.35%> (ø)
httpie/models.py 93.93% <88.88%> (-3.43%) ⬇️
httpie/manager/core.py 92.85% <92.85%> (ø)
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05c02f0...b2032dd. Read the comment docs.

@isidentical isidentical marked this pull request as ready for review December 27, 2021 13:47
httpie/client.py Outdated Show resolved Hide resolved
httpie/uploads.py Outdated Show resolved Hide resolved
httpie/uploads.py Outdated Show resolved Hide resolved
@isidentical isidentical merged commit 4c56d89 into master Dec 29, 2021
@isidentical isidentical deleted the prepare-body-rewrite branch December 29, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--chunked with --raw raises an internal error
3 participants