Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping of integer indexes with multiple backslashes #1288

Merged
merged 1 commit into from Feb 1, 2022

Conversation

isidentical
Copy link
Contributor

Resolves #1285

@codecov-commenter
Copy link

Codecov Report

Merging #1288 (8147f40) into master (4d7d6b6) will decrease coverage by 0.74%.
The diff coverage is 95.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1288      +/-   ##
==========================================
- Coverage   97.28%   96.53%   -0.75%     
==========================================
  Files          67       85      +18     
  Lines        4235     5975    +1740     
==========================================
+ Hits         4120     5768    +1648     
- Misses        115      207      +92     
Impacted Files Coverage Δ
tests/test_binary.py 100.00% <ø> (ø)
httpie/compat.py 31.11% <27.90%> (-68.89%) ⬇️
tests/conftest.py 77.14% <58.33%> (-9.82%) ⬇️
httpie/output/lexers/http.py 59.09% <59.09%> (ø)
tests/test_ssl.py 91.01% <66.66%> (-3.93%) ⬇️
httpie/manager/__main__.py 82.35% <82.35%> (ø)
httpie/output/lexers/metadata.py 82.35% <82.35%> (ø)
httpie/models.py 94.23% <90.00%> (-3.14%) ⬇️
tests/test_uploads.py 97.66% <92.15%> (-2.34%) ⬇️
httpie/manager/core.py 92.85% <92.85%> (ø)
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86ba995...8147f40. Read the comment docs.

@jkbrzt jkbrzt merged commit f1ea486 into httpie:master Feb 1, 2022
@jkbrzt
Copy link
Member

jkbrzt commented Feb 1, 2022

Great fix! I think this deserves a mention in CHANGELOG.md.

@isidentical
Copy link
Contributor Author

@jakubroztocil I think we already do (if I am not missing anything).

@isidentical
Copy link
Contributor Author

@jkbrzt
Copy link
Member

jkbrzt commented Feb 1, 2022

Sorry, yes, we do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escaping backslashes in nested json keys
3 participants