Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple parser definition from argparse #1293

Merged
merged 11 commits into from Mar 7, 2022

Conversation

isidentical
Copy link
Contributor

@isidentical isidentical commented Feb 4, 2022

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

Benchmarks

Some benchmarks were hidden from this list because their timings did not change in a significant way (change was within the error margin ±6%).


Some benchmarks were hidden from this list because their timings did not change in a significant way (change was within the error margin ±6%).


@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #1293 (c372ac8) into master (4d7d6b6) will decrease coverage by 0.52%.
The diff coverage is 95.94%.

❗ Current head c372ac8 differs from pull request most recent head 1b8cf40. Consider uploading reports for the commit 1b8cf40 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1293      +/-   ##
==========================================
- Coverage   97.28%   96.76%   -0.53%     
==========================================
  Files          67       93      +26     
  Lines        4235     6702    +2467     
==========================================
+ Hits         4120     6485    +2365     
- Misses        115      217     +102     
Impacted Files Coverage Δ
tests/test_binary.py 100.00% <ø> (ø)
httpie/compat.py 31.11% <27.90%> (-68.89%) ⬇️
tests/conftest.py 77.14% <61.53%> (-9.82%) ⬇️
httpie/manager/__main__.py 82.35% <82.35%> (ø)
httpie/output/lexers/metadata.py 82.35% <82.35%> (ø)
httpie/output/lexers/http.py 86.36% <86.36%> (ø)
tests/test_ssl.py 92.66% <87.50%> (-2.28%) ⬇️
httpie/models.py 95.19% <90.00%> (-2.18%) ⬇️
httpie/manager/tasks.py 90.41% <90.41%> (ø)
tests/test_uploads.py 97.70% <92.59%> (-2.30%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7509dd4...1b8cf40. Read the comment docs.

@isidentical isidentical marked this pull request as ready for review February 8, 2022 09:21
@isidentical isidentical force-pushed the decouple-args-from-argparse branch 4 times, most recently from c372ac8 to 436e655 Compare March 7, 2022 22:28
@isidentical isidentical merged commit 77af4c7 into master Mar 7, 2022
@isidentical isidentical deleted the decouple-args-from-argparse branch March 7, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants