Man page fixes #1364
Merged
Man page fixes #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidentical
force-pushed
the
man-page-fixes
branch
from
8958314
to
51da803
Compare
Codecov Report
@@ Coverage Diff @@
## master #1364 +/- ##
==========================================
- Coverage 97.28% 95.49% -1.80%
==========================================
Files 67 103 +36
Lines 4235 7232 +2997
==========================================
+ Hits 4120 6906 +2786
- Misses 115 326 +211
Continue to review full report at Codecov.
|
petersadek90
approved these changes
Apr 20, 2022
petersadek90
approved these changes
Apr 20, 2022
jkbrzt
reviewed
Apr 23, 2022
|
We should have that, no? |
|
Yes, even if just something super simple. E.g., a list of the management commands and a clear mention of |
|
Ah, ok. That is what I meant, it is already here. |
|
We were directly using the description which mentioned |
isidentical
force-pushed
the
man-page-fixes
branch
from
e2e07ac
to
3342f5f
Compare
|
@isidentical that’s perfect 🤩 |
isidentical
force-pushed
the
man-page-fixes
branch
6 times, most recently
from
53ba11e
to
712d9c2
Compare
petersadek90
approved these changes
Apr 30, 2022
isidentical
force-pushed
the
man-page-fixes
branch
from
712d9c2
to
107e0a6
Compare
- Highlighting for options (-x, --x) now doesn't strip the prefix (may be whitespace). - Escape sequences are now cross-platform compatible (directly taken by groff/troff [man's renderer]) - Now we check for the section before displaying the man pages. - On MacOS, there is HTTP(n) which is different from our HTTP(1). This used to conflict with it, and we showed the wrong page. Now we specifically ask foir HTTP(1). - Errors that might happen (e.g non executable man command) is now suppressed. So in the worst case (if anything regarding man execution goes wrong), we'll always display the manual. - Docs for man pages. - HTTPie man pages. - Epilog for the man pages (see also) - Auto-generated comments.
isidentical
force-pushed
the
man-page-fixes
branch
from
107e0a6
to
c81b5df
Compare
egleston
pushed a commit
to egleston/httpie
that referenced
this pull request
May 5, 2022
- Highlighting for options (-x, --x) now doesn't strip the prefix (may be whitespace). - Escape sequences are now cross-platform compatible (directly taken by groff/troff [man's renderer]) - Now we check for the section before displaying the man pages. - On MacOS, there is HTTP(n) which is different from our HTTP(1). This used to conflict with it, and we showed the wrong page. Now we specifically ask foir HTTP(1). - Errors that might happen (e.g non executable man command) is now suppressed. So in the worst case (if anything regarding man execution goes wrong), we'll always display the manual. - Docs for man pages. - HTTPie man pages. - Epilog for the man pages (see also) - Auto-generated comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-x,--x) now doesn't strip the prefix (may be whitespace).HTTP(n)which is different from ourHTTP(1). This used to conflict with it, and we showed the wrong page. Now we specifically ask foirHTTP(1).httpie(and it's own custom part telling people to useman http)