support swagger spec in yaml format #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks for contributing! |
trollfred
reviewed
Jul 17, 2019
| @@ -113,9 +114,12 @@ def cli(spec, env, url, http_options): | |||
| try: | |||
| spec = json.loads(content) | |||
| except json.JSONDecodeError: | |||
| click.secho("Warning: Specification file '%s' is not JSON" % | |||
There was a problem hiding this comment.
this is confusing, why not remove it completely?
|
When is this merged code going to be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger specs can be defined in JSON and YAML format.
This PR adds YAML support by falling back to yaml-parsing if JSON-parser throws an error.
PyYamlis required as additional requirement.