issue #172: spec/buggy Path/Operation handling #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current code expect Path object to contain only method/Operation declaration. Path object may contain $ref, summary, description, servers and parameters entries. If available, this entries are default values to apply children Operation. This fix drops unused entries ($ref, summary, description, servers) and merge parameters: * unicity based on name/in unicity * Operation value takes precedence This fix allows to parse spec file attached with httpie#172
This was referenced Feb 7, 2021
|
Thanks, @lalmeras! Can you look into the failed test? It’s basically this command : http-prompt \
https://api.github.com \
--spec \
https://raw.githubusercontent.com/github/rest-api-description/main/descriptions/api.github.com/api.github.com.json |
Parameter may be a ``{ '$ref': '...' }``. We need to use $ref, name, in
attributes for processing parameter list merging.
|
Here's a fix for the regression. I work on a test for the new feature. |
|
@lalmeras perfect, thanks! |
Path and methods parameters are merged to handle completion. Merge process is fixed to allow completion when parameters are configured only at path level.
|
Added test and PR fix. Test basically checks that all expected parameters are here when we use a path-level-only parameters definition (this is where a fix was needed) and a path-method-level parameter definition. It seems to me that the proposal is complete, and should not trigger other regressions. |
|
Merged, thanks! 🥧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code expect Path object to contain only method/Operation
declaration. Path object may contain $ref, summary, description, servers
and parameters entries.
If available, this entries are default values to apply children
Operation.
This fix drops unused entries ($ref, summary, description, servers) and
merge parameters:
This fix allows to parse spec file attached with #172