Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookies set to expire in HTTP response are not removed from session file #853

Closed
rca opened this issue Feb 15, 2020 · 2 comments · Fixed by #929
Closed

Cookies set to expire in HTTP response are not removed from session file #853

rca opened this issue Feb 15, 2020 · 2 comments · Fixed by #929
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@rca
Copy link

rca commented Feb 15, 2020

When using the --session option and storing a session in a file, when the response includes a Set-Cookie header that sets a cookie to a date in the past, the cookie is not cleared out of the session file as I would expect. Because of this, for example, cookies that are set to expire remain in the session and are still sent in subsequent requests.

Thank you.

@jkbrzt jkbrzt added the bug Something isn't working label May 12, 2020
@jkbrzt jkbrzt added the help wanted Extra attention is needed label Jun 8, 2020
@juped
Copy link

juped commented Jun 9, 2020

@kbanc and @tayoogunbiyi will be working on this! (sorry, mentioned the wrong pair first time around)

@jkbrzt
Copy link
Member

jkbrzt commented Jun 9, 2020

Sweet, @juped. I've just written some suggestions on another sessions-related issue that will be useful here as well:

#662 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants