You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Even the curl people are struggling with understanding / documenting the correct behaviour. There does not seem to be an authoritative document about it.
The text was updated successfully, but these errors were encountered:
cveilleux
changed the title
Improve no_proxy support
Improve no_proxy support
Mar 19, 2018
Both the py2 and new py3 support for the
no_proxy
env var use a simpleendswith
check inbypass_host
.There are no standards about the behaviour of no_proxy env var, but
endswith
is probably not what you want here.If domain starts with a dot (example:
.example.com
):endswith
to match any subdomain (foo.example.com
should match)example.com
should also match)If domain does not start with a dot (example:
example.com
):My understanding is that the current implementation of the check will match wrong cases:
Might be a good idea to add a test for it.
See this thread: curl/curl#1208
Even the curl people are struggling with understanding / documenting the correct behaviour. There does not seem to be an authoritative document about it.
The text was updated successfully, but these errors were encountered: