Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of file parts without filename is not supported #6

Closed
abotalov opened this issue Jan 16, 2017 · 0 comments · Fixed by #10
Closed

Creation of file parts without filename is not supported #6

abotalov opened this issue Jan 16, 2017 · 0 comments · Fixed by #10

Comments

@abotalov
Copy link
Contributor

RFC 7578 says that filename parameter is not required:

For form data that represents the content of a file, a name for the
file SHOULD be supplied as well, by using a "filename" parameter of
the Content-Disposition header field. The file name isn't mandatory
for cases where the file name isn't available or is meaningless or
private; this might result, for example, when selection or drag-and-
drop is used or when the form data content is streamed directly from
a device.

Currently filename parameter is always included if a part is file.

abotalov pushed a commit to abotalov/form_data.rb that referenced this issue Jan 21, 2017
Also allow to create file parts without filename.
Fixes httprb#5, httprb#6
@abotalov abotalov mentioned this issue Jan 21, 2017
abotalov pushed a commit to abotalov/form_data.rb that referenced this issue Jan 22, 2017
Also allow to create file parts without filename.
Fixes httprb#5, httprb#6
@ixti ixti closed this as completed in #10 Jan 22, 2017
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Jun 5, 2017
## 1.0.3 (2017-05-18)

* [#16](httprb/form_data#16)
  Fix ruby < 2.0.0 support.
  [@ixti][]


## 1.0.2 (2017-05-08)

* [#5](httprb/form_data#5)
  Allow setting Content-Type non-file parts
  [@abotalov]

* [#6](httprb/form_data#6)
  Creation of file parts without filename
  [@abotalov]

* [#11](httprb/form_data#11)
  Deprecate `HTTP::FormData::File#mime_type`. Use `#content_type` instead.
  [@ixti]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants