Add CRLF character to end of multipart body. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per RFC 1521 this character is required at the end of multipart body. Per RFC 2046 there is an optional CRLF character at the end of the multipart-body to delimit between the body and optional epilogue. Some server implementations break if this character is not added, so adding it here as it complies with both RFCs.
mhickman
force-pushed
the
fix_clrf_ending_multipart
branch
from
3b6521f
to
11b7a66
Compare
|
Awesome! Thanks! |
|
@ixti - np! I've worked around this for the time being, but any idea of when it would be included in a new release? |
|
@mhickman I'll do that ASAP. Latest - this weekend :D |
|
Thanks! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Dec 9, 2017
This version is required by newer ruby-http gem 3.0.0. Upstream changes: (from CHANGES.md) ## 2.0.0 (2017-10-01) * [#17](httprb/form_data#17) Add CRLF character to end of multipart body. [@mhickman][] ## 2.0.0.pre2 (2017-05-11) * [#14](httprb/form_data#14) Enable streaming for urlencoded form data. [@janko-m][] ## 2.0.0.pre1 (2017-05-10) * [#12](httprb/form_data#12) Enable form data streaming. [@janko-m][]
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Mar 17, 2018
## 2.1.0 (2018-03-05) * [#21](httprb/form_data#21) Rewind content at the end of `Readable#to_s`. [@janko-m][] * [#19](httprb/form_data#19) Fix buffer encoding. [@HoneyryderChuck][] ## 2.0.0 (2017-10-01) * [#17](httprb/form_data#17) Add CRLF character to end of multipart body. [@mhickman][] ## 2.0.0.pre2 (2017-05-11) * [#14](httprb/form_data#14) Enable streaming for urlencoded form data. [@janko-m][] ## 2.0.0.pre1 (2017-05-10) * [#12](httprb/form_data#12) Enable form data streaming. [@janko-m][]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per RFC 1521 this character is required at the end of multipart body.
Per RFC 2046 there is an optional CRLF character at the end of the multipart-body to delimit between the body and optional epilogue.
Some server implementations break if this character is not added, so adding it here as it complies with both RFCs.