Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes outstanding bits with socket not being correctly closed and cases when parser was received body data in one chunk.
Things to keep in mind
@socket should belong to Connection...
... and
Connection
should belong to `Response (see #72). This will allow client re-use without having any issues:With current implementation, the use-case above will be defected (res1 will never be able to read it's response body - it will be body of second request).
There's no need to keep track of Content-Length...
... and/or Transfer-Encoding. This is done by
HTTP::Parser
already. Thus we can safely rely onHTTP::Response::Parser#finished?
which is true as soon as underlyingHTTP::Parser
reports message end.Related issues
//cc @sferik @tarcieri