-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong number of arguments with http 2.2.0 and webmock #395
Comments
Looks like with version 2.2.0, specifically commit 9542da4, the signature of Since Response::Body isn't marked as private API, this should probably be considered breaking backwards compatibility? Meanwhile locking the http gem to |
Sounds like a regression. We should release a patched version that supports the old API. |
Sorry I should have replied back as I was attempting to resolve the issue. Yes @britishtea is right, locking the version to 2.1.0 works. That's what my project was using before upgrading so its fine for us for now. |
Will release http 2.2.1 with fix today |
## 2.2.1 (2017-02-06) * [#395](httprb/http#395) Fix regression of API, that broke webmock integration. ([@ixti])
I had just been updating some outdated dependencies in a project. I reviewed the changes for http but didn't expect anything breaking. I had some tests fail where we use webmock. The two are involved but I'm not sure what is wrong.
The text was updated successfully, but these errors were encountered: