Parsing POST response getting end of file reached error

[sumits]

Using the awesome http gem for parsing response from a POST request. Response is a simple JSON, ~350 bytes. Response doesn't include the Content-Length header, which is not mandatory for normal HTTP communication. Digging more in the code, problem seems to be in the body/chunk parsing code in https://github.com/tarcieri/http/blob/master/lib/http/client.rb. Here's what I am seeing

• Client requests a POST
• Client gets and formats the response (I am able to see the 'chunk' in response)
• Client creates a HTTP:Response instance
• JSON MimeType is wired properly and works
• When parsing the body, block in https://github.com/tarcieri/http/blob/master/lib/http/client.rb#L84 is hit once
• Whole chunk is read once and since @body_remaining is nil, whole block above is executed again, which tries to read the socket again - which results into a EOF reached error

I saw a couple of open issues related to the same block of code, so the logic might have to be revisited or broken down even more.

[tarcieri]

@sumits long-term fix is #39

[sumits]

Thanks Tony, makes sense - should have dug around the project more.

[tarcieri]

@sumits getting the existing code fixed would be great too! But it's due for a rewrite...

[sferik]

Can this be closed now that #39 is merged?

[tarcieri]

Yes, #39 may have new bugs, but they should at least be different than this ;)

BTW, still planning some additional cleanups to #39 as well...