Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to GitHub Actions #633

Closed
tarcieri opened this issue Dec 17, 2020 · 4 comments · Fixed by #634
Closed

Migrate to GitHub Actions #633

tarcieri opened this issue Dec 17, 2020 · 4 comments · Fixed by #634
Assignees
@ixti
Labels
Pick Me!

Comments

@tarcieri
Copy link
Member

Travis CI has changed their pricing model and it's no longer usable for OSS projects.

I would suggest migrating CI to GitHub Actions.
@tarcieri tarcieri mentioned this issue Dec 17, 2020
Merged
@ixti
Copy link
Member

ixti commented Dec 17, 2020

@tarcieri 👍

@tarcieri
Copy link
Member Author

See also #627 for more CI problems

@tarcieri
Copy link
Member Author

Here's an example template: https://github.com/postmodern/digest-crc/blob/master/.github/workflows/ruby.yml

@ixti ixti mentioned this issue Dec 20, 2020
Merged
@ixti
Copy link
Member

ixti commented Dec 20, 2020

@tarcieri thanks, started work on this, but ssl issues are kinda make it not ok to be merged yet ;))

ixti added a commit that referenced this issue Dec 20, 2020
@ixti
Switch to GitHub Actions
7d75ea9 
* Use GitHub Actions for CI
* Update Coveralls integration: generate lcov report with SimpleCov and
  send it after the test suite using coveralls GitHub Actions plugin
* Update and cleanup RSpec config
* Cleanup Rakefile
* Remove active_model dependency (certificate_authority was fixed)

PS: GH Actions syntax is ugly.
  Should we switch to Cirlce CI or GitLab CI? XD

Resolves: #633
@ixti ixti closed this as completed in #634 Dec 28, 2020
ixti added a commit that referenced this issue Dec 28, 2020
@ixti
Switch to GH-Actions (#634)
9bb0136 
* Switch to GitHub Actions

* Use GitHub Actions for CI
* Update Coveralls integration: generate lcov report with SimpleCov and
  send it after the test suite using coveralls GitHub Actions plugin
* Update and cleanup RSpec config
* Cleanup Rakefile
* Remove active_model dependency (certificate_authority was fixed)

PS: GH Actions syntax is ugly.
  Should we switch to Cirlce CI or GitLab CI? XD

Resolves: #633

* Disable SSL related specs

Specs are failing due to some misconfiguration caused by new OpenSSL.
TODO: #627

* Remove windows and macos from test matrix

We were not testing those on Travis-CI, thus to simplify migration I've
deicded to disable those. Once everything is fixed and stabilized we
will add those too.

* Bump min version of CA and rspec

Just to make sure we're using expected ones

* Make stubbed client in spec more predictable

- use stub_const
- consistently normalize URIs

* Add OpenSSL requirement details for jRuby

/cc @tarcieri Probably we should just add dependency on gem itself?

* Revert "Add OpenSSL requirement details for jRuby"

This reverts commit f8dfb38.

* Fix jRuby regression introduced in #632

jRuby is using outdated openssl gem bundled in, which don't have
validate_hostname getter on SSLContext.

* Fix jRuby coverage abilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ixti ixti

Labels
Pick Me!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to GH-Actions httprb/http
2 participants
@tarcieri @ixti