Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change not marked as breaking in changelog #700

Closed
Linuus opened this issue Nov 10, 2021 · 2 comments · Fixed by #701
Closed

Breaking change not marked as breaking in changelog #700

Linuus opened this issue Nov 10, 2021 · 2 comments · Fixed by #701

Comments

@Linuus
Copy link
Contributor

Linuus commented Nov 10, 2021

Hi!

I just upgraded the HTTPrb gem and had some issues. This PR #576 introduces a breaking change but it's not noted in the changelog as such (unless I'm missing something).
Previously, the headers were normalized when they were added so x-total-count would be stored as X-Total-Count. We then used response.to_a which returns [status, headers_as_hash, body]. Before this change, the hash keys were already normalized so when we did headers["X-Total-Count"] it worked. After this change though, it started returning nil since the hash keys didn't match anymore.

Perhaps we can update the changelog to avoid other people hitting the same issues as me? :)

@tarcieri
Copy link
Member

Please open a PR to add it

@Linuus
Copy link
Contributor Author

Linuus commented Nov 10, 2021

Please open a PR to add it

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants