Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all deprecations (closes #208) #265

Merged
merged 4 commits into from Nov 23, 2015

Conversation

tarcieri
Copy link
Member

I'd still like to go forward with a 1.0 release (and at least blog about it)

This removes all deprecations and documents replacements where applicable.

@tarcieri tarcieri force-pushed the tonyarcieri/remove-deprecations branch from 02b91ab to 0cd56ac Compare November 21, 2015 20:56
@tarcieri
Copy link
Member Author

Ugh, no Hash() in Ruby 1.9.3 😢

@zanker
Copy link
Contributor

zanker commented Nov 21, 2015

What are we waiting on to deprecate 1.9.3 again, something with the Twitter gem?

Sent from my iPhone

On Nov 21, 2015, at 12:59, Tony Arcieri notifications@github.com wrote:

Ugh, no Hash() in Ruby 1.9.3


Reply to this email directly or view it on GitHub.

@tarcieri
Copy link
Member Author

@zanker I think @sferik would prefer we don't deprecate 1.9.3 without a good reason. #242 is still open FWIW

Also locks to the latest version of RuboCop so these sorts of random RuboCop
changes don't wind up in the middle of other PRs.
@tarcieri
Copy link
Member Author

Build is green now. I'll push a 0-9-stable branch before merging this (at which point master will become 1.x)

Anyone have any thoughts on it otherwise?

@zanker
Copy link
Contributor

zanker commented Nov 23, 2015

LGTMs

@ixti
Copy link
Member

ixti commented Nov 23, 2015

👍

@tarcieri
Copy link
Member Author

:shipit:

tarcieri added a commit that referenced this pull request Nov 23, 2015
@tarcieri tarcieri merged commit a2f568b into master Nov 23, 2015
@tarcieri tarcieri deleted the tonyarcieri/remove-deprecations branch November 23, 2015 18:42
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Jan 3, 2016
## 1.0.1 (2015-12-27)

* [#283](httprb/http#283):
  Use io/wait on supported platforms.
  ([@tarcieri])

## 1.0.0 (2015-12-25)

* [#265](httprb/http#265):
  Remove deprecations ([@tarcieri]):
  - HTTP::Chainable#with_follow (use #follow)
  - HTTP::Chainable#with, #with_headers (use #headers)
  - HTTP::Chainable#auth(:basic, ...) (use #basic_auth)
  - HTTP::Chainable#default_headers (use #default_options[:headers])
  - HTTP::Headers#append (use #add)
  - HTTP::Options#[] hash-like API deprecated in favor of explicit methods
  - HTTP::Request#request_header (use #headline)
  - HTTP::Response::STATUS_CODES (use HTTP::Status::REASONS)
  - HTTP::Response::SYMBOL_TO_STATUS_CODE (no replacement)
  - HTTP::Response#status_code (use #status or #code)
  - HTTP::Response::Status#symbolize (use #to_sym)

* [#269](httprb/http#273):
  Close connection in case of error during request.
  ([@ixti])

* [#271](httprb/http#273):
  High-level exception wrappers for low-level I/O errors.
  ([@ixti])

* [#273](httprb/http#273):
  Add encoding option.
  ([@Connorhd])

* [#275](httprb/http#273):
  Support for disabling Nagle's algorithm with `HTTP.nodelay`.
  ([@nerdrew])

* [#276](httprb/http#276)
  Use Encoding::BINARY as the default encoding for HTTP::Response::Body.
  ([@tarcieri])

* [#278](httprb/http#278)
  Use an options hash for HTTP::Request initializer API.
  ([@ixti])

* [#279](httprb/http#279)
  Send headers and body in one write if possible.
  This avoids a pathological case in Nagle's algorithm.
  ([@tarcieri])

* [#281](httprb/http#281)
  Remove legacy 'Http' constant alias to 'HTTP'.
  ([@tarcieri])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants