This repository has been archived by the owner on Mar 28, 2022. It is now read-only.
feat: support api layer and global headers for testcase #94 #95 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xucong053
force-pushed
the
support-api-layer-for-testcase
branch
2 times, most recently
from
31f6703
to
28e30ca
Compare
debugtalk
reviewed
Mar 9, 2022
debugtalk
reviewed
Mar 9, 2022
xucong053
force-pushed
the
support-api-layer-for-testcase
branch
3 times, most recently
from
ad02742
to
bb69fd8
Compare
Codecov Report
@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 55.87% 57.51% +1.63%
==========================================
Files 29 29
Lines 3912 4100 +188
==========================================
+ Hits 2186 2358 +172
- Misses 1558 1576 +18
+ Partials 168 166 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xucong053
force-pushed
the
support-api-layer-for-testcase
branch
from
3c39000
to
649248a
Compare
debugtalk
reviewed
Mar 14, 2022
examples/postman-echo.json
Outdated
| } | ||
| }, | ||
| "validate": [ | ||
| { | ||
| "check": "status_code", | ||
| "assert": "equals", | ||
| "expect": 200, | ||
| "expect": 401, |
There was a problem hiding this comment.
这里预期应该还是 200，这里应该是认证信息失效了；先不改这部分，后面看下怎么处理下认证的问题
models.go
Outdated
| @@ -117,17 +118,28 @@ type Validator struct { | |||
| type TStep struct { | |||
| Name string `json:"name" yaml:"name"` // required | |||
| Request *Request `json:"request,omitempty" yaml:"request,omitempty"` | |||
| TestCase *TestCase `json:"testcase,omitempty" yaml:"testcase,omitempty"` | |||
| API string `json:"api,omitempty" yaml:"api,omitempty"` | |||
| TestCase interface{} `json:"testcase,omitempty" yaml:"testcase,omitempty"` | |||
There was a problem hiding this comment.
TestCase 和 API 都是引用，那这里是不是都统一为 string 好些？
| } | ||
|
|
||
| for _, value := range overriddenSlice { | ||
| if !builtin.Contains(slice, value) { |
There was a problem hiding this comment.
1、这里为什么需要忽略大小写？
2、即使需要忽略，在这里处理会导致 mergeSlices 函数有隐藏逻辑
There was a problem hiding this comment.
这里是直接引用hubble-go的实现，是我考虑不周，我改下
convert.go
Outdated
| tc := &TCase{} | ||
| decoder := json.NewDecoder(bytes.NewReader(file)) | ||
| decoder.UseNumber() | ||
| err = decoder.Decode(tc) | ||
| // compatible test scenario with a single API | ||
| e := json.Get(file, "request") |
There was a problem hiding this comment.
json.Get(file, "request").LastError()
response.go
Outdated
| @@ -99,15 +99,15 @@ func (v *responseObject) extractField(value string) interface{} { | |||
| return result | |||
| } | |||
|
|
|||
| func (v *responseObject) Extract(extractors map[string]string) map[string]interface{} { | |||
| func (v *responseObject) Extract(extractors map[string]interface{}) map[string]interface{} { | |||
xucong053
force-pushed
the
support-api-layer-for-testcase
branch
from
6e342d8
to
f2b8d76
Compare
debugtalk
approved these changes
Mar 15, 2022
xucong053
force-pushed
the
support-api-layer-for-testcase
branch
from
f2b8d76
to
af6c433
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: support global headers for testcase #95
feat: support API layer for testcase #94
feat: support referenced testcase by using specify testcase path in testcase script and override testcase config
fix: decode failed when content-encoding is deflate
fix: unstable RPS when high concurrency load testing