Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web Next.js stream compress example #26

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

myl7
Copy link
Contributor

@myl7 myl7 commented Jul 3, 2023

Related #23

The PR adds a runnable example of Brotli (de)compressing as a reference.
I have manually tested it with large files and ensure the output is as expected.

It can only output correctly together with the fix #25 . The example can also help to verify that fix.

@myl7
Copy link
Contributor Author

myl7 commented Jul 3, 2023

The PR currently has only compression example code.
I will add the decompression part asap since they are very similar.

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
next 13.4.7 eval, network, filesystem, shell, environment +23 973 MB vercel-release-bot
streamsaver 2.0.6 None +0 61.2 kB endless
react-dom 18.2.0 filesystem, environment +3 4.92 MB gnoff
react 18.2.0 filesystem, environment +1 322 kB gnoff

@socket-security
Copy link

socket-security bot commented Jul 3, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: next@13.4.7

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@pimterry
Copy link
Member

pimterry commented Jul 3, 2023

@SocketSecurity ignore next@*

@pimterry
Copy link
Member

pimterry commented Jul 3, 2023

@myl7 no need to worry about the Socket warnings here - I'm not worried at all about standard dependencies like this for an example app.

@pimterry pimterry merged commit d2f7278 into httptoolkit:main Jul 3, 2023
7 checks passed
@pimterry
Copy link
Member

pimterry commented Jul 3, 2023

In fact, I've just merged this directly for now. You can open a PR to add the decompression part separately, that would be useful but there's no need to make this wait for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants