-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rough in discussion of extensibility #384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure that "constant" is not the word you are looking for. Maybe use persists and persistent instead?
Co-authored-by: Roy T. Fielding <fielding@gbiv.com>
Co-authored-by: Roy T. Fielding <fielding@gbiv.com>
<t> | ||
Because CONNECT changes the request/response nature of an HTTP connection, | ||
specific HTTP versions might have different ways of mapping its semantics | ||
into the protocol's wire format. | ||
</t> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you missed my second comment that this paragraph doesn't say anything useful. AIUI, CONNECT was recently extended to allow an origin server to process it, which wasn't about the wire format.
I would prefer that we update the first paragraph to be less specific to 1.1 and then reference the CONNECT extension as an example of an allowed semantic extension because the method had no applicability for an origin server before.
I am also fine with merging this now and fixing CONNECT later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RFC 7231 already permits origin servers to process CONNECT.
An origin server that receives a CONNECT request for itself MAY respond with a 2xx (Successful) status code to indicate that a connection is established. However, most origin servers do not implement CONNECT.
But yes, that extension stretches the bounds of this description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We mention only a subset of extension points; what about content encodings, auth schemes, range units...?
For #44