Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rough in discussion of extensibility #384

Merged
merged 13 commits into from
Jul 9, 2020
Merged

Rough in discussion of extensibility #384

merged 13 commits into from
Jul 9, 2020

Conversation

mnot
Copy link
Member

@mnot mnot commented Jun 11, 2020

For #44

@mnot mnot requested review from reschke and royfielding June 11, 2020 04:07
Copy link
Member

@royfielding royfielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure that "constant" is not the word you are looking for. Maybe use persists and persistent instead?

@mnot mnot requested a review from royfielding June 22, 2020 06:21
@mnot mnot marked this pull request as ready for review June 22, 2020 06:22
draft-ietf-httpbis-semantics-latest.xml Outdated Show resolved Hide resolved
draft-ietf-httpbis-semantics-latest.xml Outdated Show resolved Hide resolved
mnot and others added 2 commits July 2, 2020 17:13
Co-authored-by: Roy T. Fielding <fielding@gbiv.com>
Co-authored-by: Roy T. Fielding <fielding@gbiv.com>
@mnot mnot requested a review from royfielding July 2, 2020 07:13
Comment on lines +5085 to +5089
<t>
Because CONNECT changes the request/response nature of an HTTP connection,
specific HTTP versions might have different ways of mapping its semantics
into the protocol's wire format.
</t>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed my second comment that this paragraph doesn't say anything useful. AIUI, CONNECT was recently extended to allow an origin server to process it, which wasn't about the wire format.

I would prefer that we update the first paragraph to be less specific to 1.1 and then reference the CONNECT extension as an example of an allowed semantic extension because the method had no applicability for an origin server before.

I am also fine with merging this now and fixing CONNECT later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFC 7231 already permits origin servers to process CONNECT.

An origin server that receives a CONNECT request for itself MAY respond with a 2xx (Successful) status code to indicate that a connection is established. However, most origin servers do not implement CONNECT.

But yes, that extension stretches the bounds of this description.

Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We mention only a subset of extension points; what about content encodings, auth schemes, range units...?

@mnot mnot merged commit ff88ac8 into master Jul 9, 2020
@mnot mnot deleted the mnot-44 branch July 9, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants