-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine requirements on If-Unmodified-Since #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a normative change that we should discuss on the mailing list. It would be good to understand why this change is being made, and if we do it, we need to list it in the Changes section.
After merging this, we should align IMS and IUS with the approach taken in #357 |
If the origin server does not have a last modification date available for | ||
the selected representation, the If-Modified-Since header field &MUST; | ||
be ignored. | ||
</t> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a new normative requirement, right? I do not object, but it would need to be called out in changes-from-rfc723*.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be easier to state that the condition evaluates to false if the target resource has no selected representation or if the selected representation has no last modification date available, since both would indicate that the resource has changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already implied by the new clause above, I think it's OK to just delete this new requirement.
If the origin server does not have a last modification date available for | ||
the selected representation, the If-Modified-Since header field &MUST; | ||
be ignored. | ||
</t> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be easier to state that the condition evaluates to false if the target resource has no selected representation or if the selected representation has no last modification date available, since both would indicate that the resource has changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still believe we need to call this out as normative change, even if it's almost just a bug fix.
Personally, I think that reduces the utility of the "changes from..." sections -- if we start noting changes this small, they're going to be swamped. I'm not going to refuse to put that in, but I don't think it's the right thing to do. @royfielding thoughts? |
I consider the "changes from" sections the place where an implementor would need to go to see what might need to be changed in an implementation. (so yes, this is an edge case, but shouldn't we include it in this case?) |
Refine requirements on If-Unmodified-Since httpwg/http-core#348 Move TE: trailers into Semantics httpwg/http-core#341 +編集(条件付きヘッダ周りの整理
Fixes #326