Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine requirements on If-Unmodified-Since #348

Merged
merged 15 commits into from
May 19, 2020
Merged

Refine requirements on If-Unmodified-Since #348

merged 15 commits into from
May 19, 2020

Conversation

mnot
Copy link
Member

@mnot mnot commented Mar 22, 2020

Fixes #326

@mnot mnot requested a review from reschke April 22, 2020 06:38
Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a normative change that we should discuss on the mailing list. It would be good to understand why this change is being made, and if we do it, we need to list it in the Changes section.

@mnot mnot requested a review from reschke April 27, 2020 05:50
draft-ietf-httpbis-semantics-latest.xml Outdated Show resolved Hide resolved
@mnot
Copy link
Member Author

mnot commented Apr 28, 2020

After merging this, we should align IMS and IUS with the approach taken in #357

If the origin server does not have a last modification date available for
the selected representation, the If-Modified-Since header field &MUST;
be ignored.
</t>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a new normative requirement, right? I do not object, but it would need to be called out in changes-from-rfc723*.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be easier to state that the condition evaluates to false if the target resource has no selected representation or if the selected representation has no last modification date available, since both would indicate that the resource has changed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already implied by the new clause above, I think it's OK to just delete this new requirement.

If the origin server does not have a last modification date available for
the selected representation, the If-Modified-Since header field &MUST;
be ignored.
</t>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be easier to state that the condition evaluates to false if the target resource has no selected representation or if the selected representation has no last modification date available, since both would indicate that the resource has changed.

@mnot mnot requested review from royfielding and reschke May 5, 2020 07:52
Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still believe we need to call this out as normative change, even if it's almost just a bug fix.

@mnot
Copy link
Member Author

mnot commented May 6, 2020

Personally, I think that reduces the utility of the "changes from..." sections -- if we start noting changes this small, they're going to be swamped. I'm not going to refuse to put that in, but I don't think it's the right thing to do. @royfielding thoughts?

@reschke
Copy link
Contributor

reschke commented May 7, 2020

I consider the "changes from" sections the place where an implementor would need to go to see what might need to be changed in an implementation. (so yes, this is an edge case, but shouldn't we include it in this case?)

@mnot mnot requested a review from reschke May 18, 2020 06:18
@royfielding royfielding merged commit 0e6043c into master May 19, 2020
@royfielding royfielding deleted the mnot-326 branch May 19, 2020 16:58
triple-underscore added a commit to triple-underscore/triple-underscore.github.io that referenced this pull request May 22, 2020
Refine requirements on If-Unmodified-Since
httpwg/http-core#348

Move TE: trailers into Semantics
httpwg/http-core#341

+編集(条件付きヘッダ周りの整理
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Handling of If-Unmodified-Since with unknown modified dates
3 participants