Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject CONNECT requests without a port #772

Merged
merged 4 commits into from Feb 16, 2021
Merged

Reject CONNECT requests without a port #772

merged 4 commits into from Feb 16, 2021

Conversation

mnot
Copy link
Member

@mnot mnot commented Feb 16, 2021

Fixes #736

Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that needs to be listed as normatice change?

@royfielding
Copy link
Member

royfielding commented Feb 16, 2021

It isn't a normative change because the ABNF already requires port to be present in this form of request. The description is just inconsistent. I also intend to change the reference to 3986 to the right section of this document.

@royfielding royfielding merged commit a5ebeb6 into master Feb 16, 2021
@royfielding royfielding deleted the mnot-736 branch February 16, 2021 18:34
royfielding added a commit that referenced this pull request Feb 16, 2021
triple-underscore added a commit to triple-underscore/triple-underscore.github.io that referenced this pull request Feb 19, 2021
A CONNECT tunnel starts after the response header section
editorial semantics
httpwg/http-core#775

An upgraded protocol starts after the 101 response
httpwg/http-core#777

Origin servers might support CONNECT
httpwg/http-core#707

Reject CONNECT requests without a port
httpwg/http-core#772

Clarify what cache proxy considerations apply to
httpwg/http-core#770

Clarify large chunk handling issues
httpwg/http-core#768

Discuss forwarding and extensibility
httpwg/http-core#773

Explain implications of statelessness
httpwg/http-core#764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Default port for CONNECT
5 participants