Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify how the target URI is extracted from 1.1 request #802

Merged
merged 11 commits into from Mar 25, 2021
Merged

clarify how the target URI is extracted from 1.1 request #802

merged 11 commits into from Mar 25, 2021

Conversation

royfielding
Copy link
Member

... components, depending on the form of request-target, and when authority might be empty.

Fixes #722

This is an alternative to #732

@royfielding
clarify how the target URI is extracted from the components, dependin…
d68b063 
…g on the form of request-target, and when authority might be empty
martinthomson
martinthomson reviewed Mar 24, 2021
View reviewed changes
Copy link
Contributor

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the text on filling in defaults. It balances my concerns very nicely.

I struggled with the authority component bullet point here. I have some suggestions for how it might be improved, but nothing concrete.

draft-ietf-httpbis-messaging-latest.xml Outdated Show resolved Hide resolved
draft-ietf-httpbis-messaging-latest.xml Outdated Show resolved Hide resolved
draft-ietf-httpbis-messaging-latest.xml Outdated Show resolved Hide resolved
draft-ietf-httpbis-messaging-latest.xml Outdated Show resolved Hide resolved
draft-ietf-httpbis-messaging-latest.xml Outdated Show resolved Hide resolved
martinthomson
martinthomson approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much improved.

draft-ietf-httpbis-messaging-latest.xml Outdated Show resolved Hide resolved
draft-ietf-httpbis-messaging-latest.xml Outdated Show resolved Hide resolved
reschke
reschke approved these changes Mar 25, 2021
View reviewed changes
draft-ietf-httpbis-messaging-latest.xml Outdated Show resolved Hide resolved
@royfielding
reverse polarity on the examples and emphasize the common case in tex…
69dbe8f 
…t so that they look more like variable assignment
martinthomson
martinthomson approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better again

@royfielding royfielding merged commit faf561e into master Mar 25, 2021
@royfielding royfielding deleted the fielding-i722 branch March 25, 2021 22:49
@royfielding royfielding mentioned this pull request Mar 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson approved these changes

@reschke reschke reschke approved these changes

@mnot mnot Awaiting requested review from mnot

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default value for Host
3 participants
@royfielding @martinthomson @reschke