require recipients to avoid smuggling/splitting attacks when processing … #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng an ambiguous message framing
mnot
approved these changes
Jul 22, 2021
|
Looks perfect to me, I particularly appreciate the explanation of the issues, which are helpful for implementations to understand what to protect against and how to act the best in a given context, thank you Roy! @mnot the 1.0 part is already explained there and for me the whole problem is covered by @royfielding 's proposal. Let's merge it as is, it's a significant improvement over previous versions. |
reschke
approved these changes
Jul 22, 2021
reschke
reviewed
Jul 22, 2021
reschke
added a commit
that referenced
this pull request
Jul 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… an ambiguous message framing
fixes #879