Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Set-Cookie headers are not well supported #1183

Closed
richanna opened this issue May 25, 2020 · 3 comments · Fixed by #2143
Closed

Multiple Set-Cookie headers are not well supported #1183

richanna opened this issue May 25, 2020 · 3 comments · Fixed by #2143

Comments

@richanna
Copy link
Contributor

The Set-Cookie header can occur multiple times but does not adhere to the list syntax, and thus is not well supported by the header field value concatenation rules.

@jricher
Copy link
Contributor

jricher commented Feb 1, 2022

Tagging @sbingler for feedback and discussion.

@sbingler
Copy link
Collaborator

sbingler commented Feb 2, 2022

Thanks, just for clarification are you looking for immediate-ish feedback from me or is this more of an FYI for future discussions?

@jricher
Copy link
Contributor

jricher commented Jun 1, 2022

Upon further investigation, I believe that combining multiple Set-Cookie fields within a signature is actually fine. The resulting value is not able to be reliably parsed, but it doesn't need to be! The canonicalized value is simply the concatenated string with defined separators between the individual values. The fact that the result is not itself a valid header value for Set-Cookie is weird, and should be called out, but I don't believe it actually negatively affects the signature process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants