Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signatures: @query clarification #1951

Closed
bblfish opened this issue Feb 8, 2022 · 0 comments · Fixed by #1964
Closed

Signatures: @query clarification #1951

bblfish opened this issue Feb 8, 2022 · 0 comments · Fixed by #1964

Comments

@bblfish
Copy link

bblfish commented Feb 8, 2022

Also: If there is no query string should the corresponding signing text be
@query: ? or @query:
ie. should the query value be empty or just consist of one ?

Should we return @query: with this request

POST /path HTTP/1.1
Host: www.example.com

and return @query: ? on this request

GET /path? HTTP/1.1
Host: www.example.com

This is what I opted for in my implementation. See

I think this is a corner case that is worth explicating very clearly, perhaps even with a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants