Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect-tcp: target_host list feature seems broken #2715

Closed
DavidSchinazi opened this issue Jan 25, 2024 · 2 comments
Closed

connect-tcp: target_host list feature seems broken #2715

DavidSchinazi opened this issue Jan 25, 2024 · 2 comments
Labels
connect-tcp draft-ietf-httpbis-connect-tcp

Comments

@DavidSchinazi
Copy link
Contributor

connect-tcp makes the target_host variable a list, which is a feature that connect-udp didn't have. I'm not an expert of URI templates, but this doesn't seem correct. The feature definition links to composite values from RFC 6570, but those require a * in the template - which is something that the document does not use in its examples nor the default template. Additionally, an example in connect-tcp uses :path = /proxy?target_host=192.0.2.1,2001:db8::1&tcp_port=443 whereas the notation from RFC 6570 would be :path = /proxy?target_host=192.0.2.1&target_host=2001:db8::1&tcp_port=443

@DavidSchinazi DavidSchinazi added the connect-tcp draft-ietf-httpbis-connect-tcp label Jan 25, 2024
@bemasc
Copy link
Contributor

bemasc commented Jan 25, 2024

No, the * is optional. Section 3.2.1 says:

If there is no explode modifier, the expansion consists of a comma-separated concatenation of the defined member string values.

This is what is shown in the example.

I've adjusted the reference (6923144) to point to a different section of RFC 6570.

@bemasc bemasc closed this as completed Jan 25, 2024
@DavidSchinazi
Copy link
Contributor Author

Thanks for clarifying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connect-tcp draft-ietf-httpbis-connect-tcp
Development

No branches or pull requests

2 participants