Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit an empty string Dictionary-ID #2721

Closed
horo-t opened this issue Jan 26, 2024 · 1 comment · Fixed by #2729
Closed

Prohibit an empty string Dictionary-ID #2721

horo-t opened this issue Jan 26, 2024 · 1 comment · Fixed by #2729

Comments

@horo-t
Copy link

horo-t commented Jan 26, 2024

Dictionary-ID was introduced to the Compression Dictionary Transport specification by #2687.

However, it is unclear whether empty string dictionary IDs are allowed.
I don't think there is any use case for an empty string dictionary ID.
So how about explicitly disallowing empty string dictionary IDs in the spec?
@pmeenan

@pmeenan
Copy link
Contributor

pmeenan commented Jan 30, 2024

I'll make a zero-length string the default and have that mean "no ID". The dictionary ID will only be sent if it has a length > 0.

pmeenan added a commit to pmeenan/http-extensions that referenced this issue Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants