Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache behavior assumes browser request includes all Variant'ed headers #731

Closed
jyasskin opened this issue Dec 1, 2018 · 0 comments · Fixed by #735
Closed

Cache behavior assumes browser request includes all Variant'ed headers #731

jyasskin opened this issue Dec 1, 2018 · 0 comments · Fixed by #735
Labels

Comments

@jyasskin
Copy link
Contributor

jyasskin commented Dec 1, 2018

https://httpwg.org/http-extensions/draft-ietf-httpbis-variants.html#cache says "... For each variant in variants-header ... Let request-value be the field-value(s) associated with field-name in incoming-request." I don't see any handling of the case where there is no field-name header in incoming-request. The algorithms in https://httpwg.org/http-extensions/draft-ietf-httpbis-variants.html#backports then also don't handle the case where request-value is empty.

Sorry if I've just missed where you handle the empty case.

@mnot mnot added the variants label Dec 2, 2018
@mnot mnot changed the title Variants: cache behavior assumes browser request includes all Variant'ed headers Cache behavior assumes browser request includes all Variant'ed headers Dec 2, 2018
@mnot mnot closed this as completed in #735 Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants