Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start mentioning trailers. See #884. #1157

Merged
merged 5 commits into from
Apr 30, 2020
Merged

Start mentioning trailers. See #884. #1157

merged 5 commits into from
Apr 30, 2020

Conversation

ioggstream
Copy link
Contributor

@ioggstream ioggstream commented Apr 15, 2020 •
edited
Loading

This PR

Mention trailers.

If received in trailers, Digest MUST NOT be discarded; instead it MAY be merged in the header section (See Section 7.1.2 of {{!MESSAGING=I-D.ietf-httpbis-messaging}}).

See #884

@ioggstream ioggstream requested a review from LPardue April 30, 2020 09:53
LPardue
LPardue requested changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@LPardue LPardue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of readability suggestions, and a question about normative requirements.

ioggstream and others added 3 commits April 30, 2020 12:46
@ioggstream
Digest in trailer should not be discarded.
180aa31
@ioggstream @LPardue
Improve wordings
210e0cb 
Co-Authored-By: Lucas Pardue <lucaspardue.24.7@gmail.com>
@ioggstream @LPardue
Update draft-ietf-httpbis-digest-headers.md
c243b7f 
Co-Authored-By: Lucas Pardue <lucaspardue.24.7@gmail.com>
LPardue
LPardue approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@LPardue LPardue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ioggstream ioggstream requested a review from LPardue April 30, 2020 10:54
ioggstream
ioggstream commented Apr 30, 2020
View reviewed changes
draft-ietf-httpbis-digest-headers.md
Comment on lines +1045 to +1047
If received in trailers, Digest MUST NOT be discarded;
instead it MAY be merged in the header section (See Section 7.1.2 of {{!MESSAGING=I-D.ietf-httpbis
-messaging}}).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LPardue sorry Lucas, could you please check this part I stumbled upon re-reading http-messaging-latest?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ioggstream ioggstream merged commit 0b61fc8 into master Apr 30, 2020
@ioggstream ioggstream deleted the ioggstream-884-trailers branch April 30, 2020 11:01
@ioggstream ioggstream mentioned this pull request Apr 30, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson Awaiting requested review from martinthomson

@LPardue LPardue Awaiting requested review from LPardue

Assignees
No one assigned
Labels
digest-headers
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ioggstream @LPardue