[Client Hints] Address Genart review comments #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping! :) |
mnot
reviewed
May 11, 2020
mnot
reviewed
May 11, 2020
draft-ietf-httpbis-client-hints.md
Outdated
|
|
||
|
|
||
| --- abstract | ||
|
|
||
| HTTP defines proactive content negotiation to allow servers to select the appropriate response for a given request, based upon the user agent's characteristics, as expressed in request headers. In practice, clients are often unwilling to send those request headers, because it is not clear whether they will be used, and sending them impacts both performance and privacy. | ||
| HTTP defines proactive content negotiation to allow servers to select the appropriate response for a given request, based upon the client's characteristics, as expressed in request headers. In practice, clients are often unwilling to send those request headers, because it is not clear whether they will be used, and sending them impacts both performance and privacy. |
There was a problem hiding this comment.
Here and elsewhere, changing "user agent" to "client" implies that the scope of discussion -- including requirements -- includes intermediaries as well as UAs. Is that intentional?
There was a problem hiding this comment.
That's a good point, I haven't considered intermediaries. One of the points raised in the review was to align on either "client" or "user agent". I guess it'd be more appropriate to align on the latter.
There was a problem hiding this comment.
Aligned on user agent. Let me know if that works
|
Friendly ping! :) PTAL? |
|
LGTM |
|
Thanks for reviewing!! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.