Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detail encryption quirks #1285

Merged
merged 3 commits into from Oct 12, 2020
Merged

Detail encryption quirks #1285

merged 3 commits into from Oct 12, 2020

Conversation

ioggstream
Copy link
Contributor

This PR

details encryption quirks:

  • encryption functions may produce different results with the same data
  • this means that if I GET an encrypted resource twice, I could get two different digest values
  • so the digest value is just good to validate the ongoing message and not for further processing of the data at rest, unless I store the encrypted data or use an id- algorithm which in turn might disclose information.

This

@ioggstream ioggstream mentioned this pull request Oct 9, 2020
Closed
12 tasks
LPardue
LPardue reviewed Oct 11, 2020
View reviewed changes
Copy link
Contributor

@LPardue LPardue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some nits.

draft-ietf-httpbis-digest-headers.md Outdated Show resolved Hide resolved
draft-ietf-httpbis-digest-headers.md Outdated Show resolved Hide resolved
ioggstream and others added 2 commits October 12, 2020 09:19
@ioggstream @LPardue
typo
e1490fc 
Co-authored-by: Lucas Pardue <lucaspardue.24.7@gmail.com>
@ioggstream @LPardue
typo
898310b 
Co-authored-by: Lucas Pardue <lucaspardue.24.7@gmail.com>
@ioggstream ioggstream merged commit bf83947 into master Oct 12, 2020
@ioggstream ioggstream deleted the ioggstream-1250-encrypted-coding branch October 12, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPardue LPardue LPardue left review comments

Assignees
No one assigned
Labels
digest-headers
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ioggstream @LPardue