Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SETTINGS_NO_RFC7540_PRIORITIES #1706

Merged
merged 2 commits into from
Sep 30, 2021
Merged

SETTINGS_NO_RFC7540_PRIORITIES #1706

merged 2 commits into from
Sep 30, 2021

Conversation

martinthomson
Copy link
Contributor

RFC 7540 priorities are already deprecated.

RFC 7540 priorities are already deprecated.
Copy link
Contributor

@kazuho kazuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed changes look good.

In addition, I think we might want to change the use of lower-case "deprecate" in Appendix A:

The ability to deprecate HTTP/2 prioritization is based on I-D.lassey-priority-setting

For this case, maybe changing deprecate to depreciate would be the minimum required change.

@LPardue
Copy link
Contributor

LPardue commented Sep 30, 2021

For this case, maybe changing deprecate to depreciate would be the minimum required change.

That's the kind of thing I expect reviewers to question if we made a typo :)

How about just changing the text to "using a setting to disable RFC 7540 priorities was inspired by I-D.lassey-priority-setting?

Alternatively, we could just drop the mention altogther, although I think the context is useful.

@kazuho
Copy link
Contributor

kazuho commented Sep 30, 2021

"disable" WFM.

@LPardue LPardue merged commit 1281b42 into main Sep 30, 2021
@LPardue LPardue deleted the no-7540 branch September 30, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants