Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State we are using BCP 14 #1784

Merged
merged 2 commits into from Nov 17, 2021
Merged

State we are using BCP 14 #1784

merged 2 commits into from Nov 17, 2021

Conversation

LPardue
Copy link
Contributor

@LPardue LPardue commented Nov 15, 2021

point 1 of #1783

@LPardue LPardue requested a review from kazuho as a code owner November 15, 2021 20:16
martinthomson
martinthomson reviewed Nov 16, 2021
View reviewed changes
Copy link
Contributor

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another way.

draft-ietf-httpbis-priority.md Outdated Show resolved Hide resolved
draft-ietf-httpbis-priority.md Outdated Show resolved Hide resolved
@LPardue @martinthomson
TIL macro magic
35131a8 
Co-authored-by: Martin Thomson <martin.thomson@gmail.com>
kazuho
kazuho approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@kazuho kazuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for the fix.

@LPardue LPardue merged commit 958db7d into main Nov 17, 2021
@LPardue LPardue deleted the priority-boilerplate branch November 17, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson left review comments

@kazuho kazuho kazuho approved these changes

Assignees
No one assigned
Labels
priorities
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LPardue @kazuho @martinthomson