New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: #1834. Remove incremental algorithms. #1848
Conversation
The new text looks ok but since it only appears in the Representation Digest section, it gives the impression that it doesn't apply to content digest. |
@LPardue PTAL |
draft-ietf-httpbis-digest-headers.md
Outdated
When it is convenient to do so, | ||
the sender and the receiver can dynamically compute the checksum value | ||
while streaming the content. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an idea, what do you think about moving these 3 paragraphs to above the declaration of the registry? I could propose a follow up PR to this one if its easier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LPardue Great, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it... PTAL
8cec327
to
9e9f0ad
Compare
draft-ietf-httpbis-digest-headers.md
Outdated
digest-algorithm = token | ||
~~~ | ||
|
||
When it is convenient to do so, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see some indication of what would make it "convenient" here -- this is as unclear as "incremental" was before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably it's better to mention incremental algorithms then :P
When it is convenient to do so, | |
When using algorithms based on incremental computation, | |
(see {{?RFC1624}}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively just pass the ball to implementers.
When it is convenient to do so, | |
When implementers deem convenient to do so, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LPardue if none of the above solutions work, I'd just remove these 3 lines since checksum implementers already know that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets just delete it
This PR
Fix: #1834. Remove incremental algorithms.
@LPardue tweak the text as you prefer and merge :)