Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State even more clearly intermediary unfairness #2053

Merged

Conversation

LPardue
Copy link
Contributor

@LPardue LPardue commented Mar 29, 2022

Fixes #2011

This ended up being larger than I wanted, I'm not a huge fan of that. But I think this scope of change is needed if we want to be crystal clear, even if the words I've proposed need to be tweaked.

Based on @MikeBishop's suggestion on the the issue (thanks!)

@LPardue LPardue requested a review from kazuho as a code owner March 29, 2022 17:24
@LPardue LPardue force-pushed the priority-auth48-intermediary-forwarding-fairness branch from 945abc9 to 761dc89 Compare March 29, 2022 17:25
@LPardue LPardue force-pushed the priority-auth48-intermediary-forwarding-fairness branch from 761dc89 to 0b46573 Compare March 29, 2022 17:26
Copy link
Contributor

@kazuho kazuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I might propose splitting sentence between what happens without priority signals and what happens with. But I think that's a matter of taste, so I would be fine with what is being proposed.

draft-ietf-httpbis-priority.md Outdated Show resolved Hide resolved
Co-authored-by: Kazuho Oku <kazuhooku@gmail.com>
@LPardue
Copy link
Contributor Author

LPardue commented Apr 7, 2022

I liked your suggestion so I took it!

@LPardue LPardue merged commit 97e8e0e into priority-auth48-all Apr 13, 2022
@LPardue LPardue deleted the priority-auth48-intermediary-forwarding-fairness branch April 13, 2022 13:10
LPardue added a commit that referenced this pull request Jun 9, 2022
* State even more clearly intermediary unfairness

Co-authored-by: Kazuho Oku <kazuhooku@gmail.com>
LPardue added a commit that referenced this pull request Jun 10, 2022
* uncontroversial AUTH48 (#2044)
* priority: update author name (#1978)

* Update author name

kramdown-rfc2629 v 1.5.26 added the ability for non-ascii names
in markdown that don't generate XML that xml2rfc would reject.


Co-authored-by: Martin Thomson <mt@lowentropy.net>

* always RFC stream priorities

* IANA considerations style fixups (#2050)

* streams carry requests, not methods (#2052)

* couple of IANA fixups

* priority parameters are lowercase

* lowercase Stream and Push ID in prose

* Priority Field Value

* false is <tt> too

* Tweak the acknowledgements

* Add priority keywords (#2056)

* rephrase multiplexing speak on H1.1 and older (#2055)

* Frame defs and examples are art (#2054)

* add clarifying statements about stream state outcomes (#2051)

* s/Specification:/Reference:

* totally after is totally lame

* you consult a doctor, not an HTTP request

* tweak contrast of frames and headers

* their values -> its value

* avoiding -> preventing

* CDN is actually uppercase

* fix external refs

* remove changelog

* benefit sending -> benefit in sending

* one more tt for true

* H2 frame format

* H2 frame format comma not dot

* apparently all i.e. need a comma

* either -> in either of

* Prioritized stream -> prioritized stream

* open -> open state

* no comma here!

* align refs with HTTP style (#2057)

* priority: use SF terms, not ABNF (#1977)

* priority: use SF terms, not ABNF

* Tweak IANA stuff (#2059)

Closes #2006

A parameter by any name would be sweet

* Try to avoid saying payload where it is not needed (#2060)

* remove superfluous description of H2 reserved field

* auth48 tiny editorial nits (#2067)

* s/Structured Fields Dictionary/Dictionary/

* either of the "half-closed" state(s)

* was originally "the CONNECT method"

* Intermediary signal processing/production, again (#2058)

Closes #2003

* State even more clearly intermediary unfairness (#2053)

* State even more clearly intermediary unfairness

Co-authored-by: Kazuho Oku <kazuhooku@gmail.com>

* Add space to author name

Co-authored-by: Martin Thomson <mt@lowentropy.net>
Co-authored-by: Kazuho Oku <kazuhooku@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants