-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State even more clearly intermediary unfairness #2053
Merged
LPardue
merged 2 commits into
priority-auth48-all
from
priority-auth48-intermediary-forwarding-fairness
Apr 13, 2022
Merged
State even more clearly intermediary unfairness #2053
LPardue
merged 2 commits into
priority-auth48-all
from
priority-auth48-intermediary-forwarding-fairness
Apr 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
945abc9
to
761dc89
Compare
761dc89
to
0b46573
Compare
kazuho
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I might propose splitting sentence between what happens without priority signals and what happens with. But I think that's a matter of taste, so I would be fine with what is being proposed.
Co-authored-by: Kazuho Oku <kazuhooku@gmail.com>
I liked your suggestion so I took it! |
LPardue
added a commit
that referenced
this pull request
Jun 9, 2022
* State even more clearly intermediary unfairness Co-authored-by: Kazuho Oku <kazuhooku@gmail.com>
LPardue
added a commit
that referenced
this pull request
Jun 10, 2022
* uncontroversial AUTH48 (#2044) * priority: update author name (#1978) * Update author name kramdown-rfc2629 v 1.5.26 added the ability for non-ascii names in markdown that don't generate XML that xml2rfc would reject. Co-authored-by: Martin Thomson <mt@lowentropy.net> * always RFC stream priorities * IANA considerations style fixups (#2050) * streams carry requests, not methods (#2052) * couple of IANA fixups * priority parameters are lowercase * lowercase Stream and Push ID in prose * Priority Field Value * false is <tt> too * Tweak the acknowledgements * Add priority keywords (#2056) * rephrase multiplexing speak on H1.1 and older (#2055) * Frame defs and examples are art (#2054) * add clarifying statements about stream state outcomes (#2051) * s/Specification:/Reference: * totally after is totally lame * you consult a doctor, not an HTTP request * tweak contrast of frames and headers * their values -> its value * avoiding -> preventing * CDN is actually uppercase * fix external refs * remove changelog * benefit sending -> benefit in sending * one more tt for true * H2 frame format * H2 frame format comma not dot * apparently all i.e. need a comma * either -> in either of * Prioritized stream -> prioritized stream * open -> open state * no comma here! * align refs with HTTP style (#2057) * priority: use SF terms, not ABNF (#1977) * priority: use SF terms, not ABNF * Tweak IANA stuff (#2059) Closes #2006 A parameter by any name would be sweet * Try to avoid saying payload where it is not needed (#2060) * remove superfluous description of H2 reserved field * auth48 tiny editorial nits (#2067) * s/Structured Fields Dictionary/Dictionary/ * either of the "half-closed" state(s) * was originally "the CONNECT method" * Intermediary signal processing/production, again (#2058) Closes #2003 * State even more clearly intermediary unfairness (#2053) * State even more clearly intermediary unfairness Co-authored-by: Kazuho Oku <kazuhooku@gmail.com> * Add space to author name Co-authored-by: Martin Thomson <mt@lowentropy.net> Co-authored-by: Kazuho Oku <kazuhooku@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2011
This ended up being larger than I wanted, I'm not a huge fan of that. But I think this scope of change is needed if we want to be crystal clear, even if the words I've proposed need to be tweaked.
Based on @MikeBishop's suggestion on the the issue (thanks!)