Add signature context #2222
Merged
Add signature context #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaronf
reviewed
Jul 16, 2022
Co-authored-by: Yaron Sheffer <yaronf@gmx.com>
richanna
requested changes
Jul 29, 2022
| @@ -480,6 +480,7 @@ The signature parameters component value is the serialization of the signature p | |||
| * `nonce`: A random unique value generated for this signature as a String value. | |||
| * `alg`: The HTTP message signature algorithm from the HTTP Message Signature Algorithm Registry, as a String value. | |||
| * `keyid`: The identifier for the key material as a String value. | |||
| * `context`: A context for the signature as a String value. This value is used by applications to help identify the signature's validity in specific applications or protocols. Context is often needed for avoiding cross-protocol attacks. | |||
There was a problem hiding this comment.
Suggested change
| * `context`: A context for the signature as a String value. This value is used by applications to help identify the signature's validity in specific applications or protocols. Context is often needed for avoiding cross-protocol attacks. | |
| * `context`: A context for the signature as a String value. This value may be used by applications to help identify the intended usage of the signature. |
I'm still not thrilled by the second sentence, but this wording seems more accurate to me. The third sentence is simply not true. Signing all components that are semantically meaningful to the application will prevent cross-protocol attacks in most cases; in the remaining cases, there is no reason to assume context will provide any additional mitigation.
jricher
requested review from
yaronf and
richanna
and removed request for
yaronf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional
contextparameter to signatures, to allow applications to signal specific usage between the signer and verifier.Closes #2133
This PR does not add this to any examples yet, but we probably should if accepted.